Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db_config.use_wal #1860

Closed
LaurenceJJones opened this issue Nov 7, 2022 · 1 comment · Fixed by #1863
Closed

db_config.use_wal #1860

LaurenceJJones opened this issue Nov 7, 2022 · 1 comment · Fixed by #1863
Assignees
Labels
kind/enhancement New feature or request

Comments

@LaurenceJJones
Copy link
Contributor

What would you like to be added?

The new message about use_wal doesn't really describe how to enable it well. We should include a commented out line so user doesnt need to think about un commenting it.

time="07-11-2022 10:04:34" level=warning msg="you are using sqlite without WAL, this can have an impact of performance. If you do not store the database in a network share, set db_config.use_wal to true. Set explicitly to false to disable this warning." context=ent

Why is this needed?

For ease for users to enable it without needing to think what key is.

@buixor
Copy link
Contributor

buixor commented Nov 7, 2022

I think the message itself is quite ok ? however it repeats too much at startup, so I can try to make it repeat only once

buixor added a commit that referenced this issue Nov 7, 2022
buixor added a commit that referenced this issue Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants