default "cscli machines add" to write credentials to stdout, require explicit path to overwrite local_api_credentials.yaml #2594
Conversation
explicit path to overwrite local_api_credentials.yaml
|
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2594 +/- ##
==========================================
- Coverage 57.24% 51.88% -5.37%
==========================================
Files 190 109 -81
Lines 26156 14576 -11580
==========================================
- Hits 14974 7563 -7411
+ Misses 9605 6177 -3428
+ Partials 1577 836 -741
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| err = os.WriteFile(dumpFile, apiConfigDump, 0644) | ||
|
|
||
| if dumpFile == "" { | ||
| fmt.Printf("%s\n", string(apiConfigDump)) |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
mmetc
force-pushed
the
machines-add-stdout
branch
from
ca51493
to
4018e67
Compare
Draft until we decide a deprecation path, if the change is accepted.
Notably, the installation scripts have to be updated before this change goes into effect.