cscli machines add: don't overwrite existing credential file #2625
Conversation
|
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
|
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2625 +/- ##
=======================================
Coverage 58.22% 58.23%
=======================================
Files 201 201
Lines 27048 27056 +8
=======================================
+ Hits 15750 15757 +7
- Misses 9753 9755 +2
+ Partials 1545 1544 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mmetc
force-pushed
the
machines-add-local
branch
4 times, most recently
from
5ea0564
to
6264fc3
Compare
mmetc
force-pushed
the
machines-add-local
branch
from
c0043fa
to
59007ed
Compare
Now --force is used both to override the replacement of and existing machine, and an existing credentials file. To retain the old behavior, the existence of the file is only checked for the default configuration, not if explicitly specified.
mmetc
force-pushed
the
machines-add-local
branch
from
59007ed
to
d8092db
Compare
Simpler alternative to #2594
to fix #2567
The command returns with an error if a file is not specified and the local credentials file already exists. Explicitly providing a path will happily overwrite. Using --force will also overwrite.