-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cscli config show: pretty print struct output #2633
Conversation
@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2633 +/- ##
==========================================
+ Coverage 58.22% 58.24% +0.01%
==========================================
Files 201 201
Lines 27048 27048
==========================================
+ Hits 15750 15754 +4
+ Misses 9753 9749 -4
Partials 1545 1545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR allows a user to discover field names in the run-time configuration without searching the source code.
The only issue I see is that some custom types like logrus.Level are not marshaled, i.e. will print "4" instead of "info" like the version with "%v". But it handles pointers and even recursive structures, so it can be a more readable (if less detailed) alternative to spew.
An alternative to litter would be kylelemons/godebug, which is less verbose (does not print struct names which are useless in this case) but has the same issue with LogLevel.