Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lapi detailed metrics #2858

Merged
merged 145 commits into from
Jul 24, 2024
Merged

Lapi detailed metrics #2858

merged 145 commits into from
Jul 24, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Feb 23, 2024

No description provided.

Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 72.94118% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 58.07%. Comparing base (8e9e091) to head (6abcafb).

Files Patch % Lines
pkg/apiserver/controllers/v1/usagemetrics.go 40.90% 10 Missing and 3 partials ⚠️
cmd/crowdsec/lpmetrics.go 83.56% 9 Missing and 3 partials ⚠️
pkg/csconfig/console.go 57.14% 6 Missing and 3 partials ⚠️
cmd/crowdsec/crowdsec.go 82.35% 3 Missing ⚠️
pkg/apiclient/usagemetrics.go 78.57% 2 Missing and 1 partial ⚠️
pkg/apiserver/controllers/controller.go 75.00% 1 Missing and 2 partials ⚠️
cmd/crowdsec/serve.go 50.00% 2 Missing ⚠️
cmd/crowdsec/main.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2858      +/-   ##
==========================================
+ Coverage   57.98%   58.07%   +0.08%     
==========================================
  Files         240      243       +3     
  Lines       31040    31190     +150     
==========================================
+ Hits        18000    18113     +113     
- Misses      11411    11437      +26     
- Partials     1629     1640      +11     
Flag Coverage Δ
bats 38.20% <72.94%> (+0.21%) ⬆️
unit-linux 52.13% <11.26%> (-0.13%) ⬇️
unit-windows 47.67% <5.40%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 52.82584% with 409 lines in your changes missing coverage. Please review.

Project coverage is 50.84%. Comparing base (61d19cf) to head (01479b8).

Files Patch % Lines
pkg/apiserver/apic_metrics.go 5.52% 154 Missing ⚠️
pkg/apiserver/controllers/v1/usagemetrics.go 47.79% 76 Missing and 7 partials ⚠️
cmd/crowdsec-cli/climetrics/statbouncer.go 73.54% 36 Missing and 5 partials ⚠️
cmd/crowdsec/lpmetrics.go 64.95% 39 Missing and 2 partials ⚠️
pkg/database/metrics.go 57.69% 19 Missing and 3 partials ⚠️
pkg/database/ent/metric/where.go 11.11% 16 Missing ⚠️
pkg/database/flush.go 58.33% 7 Missing and 3 partials ⚠️
pkg/apiclient/usagemetrics.go 42.85% 6 Missing and 2 partials ⚠️
pkg/database/machines.go 82.05% 6 Missing and 1 partial ⚠️
cmd/crowdsec/serve.go 40.00% 5 Missing and 1 partial ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2858      +/-   ##
==========================================
+ Coverage   49.61%   50.84%   +1.23%     
==========================================
  Files         322      326       +4     
  Lines       37891    38582     +691     
==========================================
+ Hits        18799    19617     +818     
+ Misses      17248    17035     -213     
- Partials     1844     1930      +86     
Flag Coverage Δ
bats 40.12% <59.28%> (+1.76%) ⬆️
unit-linux 33.96% <21.92%> (-0.18%) ⬇️
unit-windows 28.48% <16.83%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc force-pushed the lapi-detailed-metrics branch 3 times, most recently from f7c38d2 to 74cf0d9 Compare March 14, 2024 11:59
@mmetc mmetc marked this pull request as ready for review July 18, 2024 11:53
@blotus blotus merged commit 64e4ecd into master Jul 24, 2024
16 of 17 checks passed
@blotus blotus deleted the lapi-detailed-metrics branch July 24, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants