Skip to content
This repository has been archived by the owner on Aug 1, 2022. It is now read-only.

Verify against example #6

Merged
merged 13 commits into from
Jul 13, 2021

Conversation

halvardssm
Copy link
Contributor

Hi @crowlKats ! I've been using your lib a bit more, and I did another addition. Let me know if you are ok with this feature as well!

@halvardssm
Copy link
Contributor Author

Another addition (haven't made it yet though), could be to have an option of using the example file as default options. What do you think about this?

Cleaned up options
Updated readme
General cleanup and comments
@halvardssm
Copy link
Contributor Author

Hi @crowlKats ! I made a small update to the PR, please let me know if this is still within your vision of the module or if you want any changes 😄

@crowlKats
Copy link
Owner

@halvardssm first off, i am extremely sorry for not having reviewed this earlier; was going to do it the afternoon you opened it, but ended up being busy for a while and then completely forgot about it.
Secondly, what exactly is the usecase for this?

@halvardssm
Copy link
Contributor Author

@crowlKats No worries! I also forgot about this PR until I was using denv the other day. So the usecase for this includes when you have advanced config, multiple pipelines and environments, and you are including a .env.example file in your repository.

verifyAgainstExample: The example file can be used to validate the environment at the launch stage rather than during runtime. Say you need a secret for one specific call and it is only used occasionally, meaning you won't catch the missing env before you need it.

defaultToExample: The example file can include default values to use with development.

exampleFile: In case your .env.example is not in the root of the project directory.

Of course, all of these usecases might not be that widely used, but I needed them, so there might be others which might need them too.

@crowlKats
Copy link
Owner

Oh I see. Well, I don't mind having them, so lets add them!

@crowlKats crowlKats merged commit 15e48a2 into crowlKats:master Jul 13, 2021
@halvardssm halvardssm deleted the feat/verify-against-example branch July 13, 2021 09:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants