Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White line augmentation artifact #2

Closed
samedii opened this issue Jun 26, 2022 · 3 comments
Closed

White line augmentation artifact #2

samedii opened this issue Jun 26, 2022 · 3 comments

Comments

@samedii
Copy link

samedii commented Jun 26, 2022

Thank you for open sourcing this! I tried out your implementation of the non-leaky augmentations. In case it's helpful to you I noticed that there seem to be some artifacts created in the augmentation pipeline that will probably not help in training

Left is normal. Right has an added white line
image

(I have a different implementation that I built a couple of weeks ago but I didn't do the non-leaky augmentations then. For what it's worth I can say that I've also gotten better results with these techniques than for example v-diff on small real world datasets)

@samedii
Copy link
Author

samedii commented Jun 26, 2022

I looked at it and this is just caused by order=3, clip=False and then me converting to uint8 which makes it look white but it's actually overflowed (negative). I don't think this is an issue for you

@samedii samedii closed this as completed Jun 26, 2022
@crowsonkb
Copy link
Owner

crowsonkb commented Jun 26, 2022 via email

@samedii
Copy link
Author

samedii commented Jun 28, 2022

Only seen degradations with the non-leaky augmentations so far but I saw that you've made some updates to it so maybe I'll try again

infinitewarp pushed a commit to infinitewarp/k-diffusion that referenced this issue May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants