New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't check sys.modules before dynamic import #94

Merged

svituz merged 1 commit into crs4:develop from r1b:fix/sys-modules-threads

Aug 26, 2021

Contributor

r1b commented Aug 9, 2021 •

edited

Loading

importlib.import_module already does this.
Moreover, you must acquire the import lock before checking sys.modules. importlib.import_module does this for you.

Fixes #61


          fix: don't check sys.modules before dynamic import

cb3a03a

1. `importlib.import_module` [already does this](https://github.com/python/cpython/blob/7d14fdb03c3e8384c01da1b21647ce837ed6a29c/Lib/importlib/_bootstrap.py#L1033-L1046)
2. Moreover, you must acquire the import lock before checking sys.modules. `importlib.import_module` does this for you.

Fixes crs4#61

Member

svituz commented Aug 26, 2021

Thanks for your contribution and for closing a long-standing bug

svituz merged commit ebca2a0 into crs4:develop

r1b deleted the fix/sys-modules-threads branch

August 27, 2021 00:31

svituz mentioned this pull request

Multi-Threading support in HL7APY #95

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment