Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't check sys.modules before dynamic import #94

Merged
merged 1 commit into from
Aug 26, 2021
Merged

fix: don't check sys.modules before dynamic import #94

merged 1 commit into from
Aug 26, 2021

Commits on Aug 9, 2021

  1. fix: don't check sys.modules before dynamic import 

    1. `importlib.import_module` [already does this](https://github.com/python/cpython/blob/7d14fdb03c3e8384c01da1b21647ce837ed6a29c/Lib/importlib/_bootstrap.py#L1033-L1046)
2. Moreover, you must acquire the import lock before checking sys.modules. `importlib.import_module` does this for you.

Fixes crs4#61
    @r1b
    r1b committed Aug 9, 2021
    Configuration menu
    Copy the full SHA
    cb3a03a View commit details
    Browse the repository at this point in the history