Adding Visual Expectations for Plotting Functions #572
+2,862
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @crsh,
It is still one of my aims to refactor the family of
apa_*plot()
functions in the future. Actually, I already drafted a powerful approach, but the changes are so extensive that it is practically impossible to review these changes all at once and I also want to take some precautions not to break older code.Therefore, I thought it is wise to first add visual expectations (via the vdiffr package) before I start adding theses changes one by one.
This PR is intended to get github actions running, and to gain some experience with vdiffr. I will require your review as soon as I have the impression that we can add these tests to the main branch. In the meantime, any feedback on how to improve the testing pipeline is highly appreciated.