scserver: explicitly kill child process

In Electron it was re-parenting the scsynth child process rather than shutting it down.

src/server/server.js

@@ -203,16 +203,22 @@ export class Server extends EventEmitter {
 
     this.processEvents.onNext('Start process: ' + execPath + ' ' + args.join(' '));
     this.process = spawn(execPath, args, {
-      cwd: this.options.cwd
+      cwd: this.options.cwd,
+      options: {
+        detached: false
+      }
     });
     this.processEvents.onNext('pid: ' + this.process.pid);
 
     // when this parent process dies, kill child process
-    process.on('exit', () => {
+    let killChild = () => {
       if (this.process) {
         this.process.kill('SIGTERM');
+        this.process = null;
       }
-    });
+    };
+
+    process.on('exit', killChild);
 
     this.process.on('error', (err) => {
       this.processEvents.onError(err);
@@ -291,7 +297,13 @@ export class Server extends EventEmitter {
       this.osc.close();
       delete this.osc;
     }
-    this._serverObservers.forEach((obs) => obs.dispose());
+
+    // TODO: its the subscriptions that need to be disposed, these are the Observables
+    // this._serverObservers.forEach((obs) => obs.dispose());
+    // for (var key in this._serverObservers) {
+    //   console.log(key, this._serverObservers[key], this._serverObservers[key].dispose);
+    //   this._serverObservers[key].dispose();
+    // }
     this._serverObservers = {};
   }