Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR introduces support for push constants (or root constants in DX 12). The concept of push constants originates from the Vulkan spec and describes a small chunk of memory that can be directly written to the command buffer and read by shaders on a per-draw-call base. There are certain restrictions, though:
In DirectX, push constants are most closely resembled by root constants, which are directly written into the command buffer as 4 byte chunks of raw memory. Overlapping is not supported in this case, thus the implementation will duplicate overlapping memory blocks.
DXC has a the attribute
[[vk::push_constant]]
, which (in combination with[[vk::offset]]
) can be used to directly read push constants in Vulkan. For DirectX, root constants are bound to a register/space, as typical constant buffers.Related issues