This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
generated from cruise-automation/oss-template
Add EmptyDir size limit policy #40
Merged
dustin-decker
merged 6 commits into
cruise-automation:master
from
alpe:alex/size_limit_mutation_policy_36
Jan 9, 2020
Merged
Add EmptyDir size limit policy #40
dustin-decker
merged 6 commits into
cruise-automation:master
from
alpe:alex/size_limit_mutation_policy_36
Jan 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpe
force-pushed
the
alex/size_limit_mutation_policy_36
branch
from
January 6, 2020 14:58
9b26ec4
to
e262eab
Compare
alpe
changed the title
Initial version PolicyEmptyDirSizeLimit
Add EmptyDir size limit policy
Jan 6, 2020
alpe
force-pushed
the
alex/size_limit_mutation_policy_36
branch
from
January 7, 2020 12:29
9d19d83
to
f848797
Compare
❓What's left to do to in this PR to get it merged? @jleadford @dustin-decker |
dustin-decker
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work. Thank you for the contribution, the thorough testing, and the configuration enhancements!
I will cut a release to include this soon. |
Released in v1.3.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
PolicyEmptyDirSizeLimit
policy which:emptyDir
volumeThere is an edge case with a size limit in the volume set to
0
. It is handled like a non set size limit (nil
).Resolves #36