Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Add EmptyDir size limit policy #40

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Dec 30, 2019

Adds the PolicyEmptyDirSizeLimit policy which:

  • sets the configured default size when none is set for an emptyDir volume
  • reports a violation when the size is greater then the configured max size

There is an edge case with a size limit in the volume set to 0. It is handled like a non set size limit (nil).

Resolves #36

@alpe alpe force-pushed the alex/size_limit_mutation_policy_36 branch from 9b26ec4 to e262eab Compare January 6, 2020 14:58
@alpe alpe changed the title Initial version PolicyEmptyDirSizeLimit Add EmptyDir size limit policy Jan 6, 2020
@alpe alpe marked this pull request as ready for review January 6, 2020 16:58
@alpe alpe force-pushed the alex/size_limit_mutation_policy_36 branch from 9d19d83 to f848797 Compare January 7, 2020 12:29
@alpe
Copy link
Contributor Author

alpe commented Jan 9, 2020

❓What's left to do to in this PR to get it merged? @jleadford @dustin-decker

Copy link
Contributor

@dustin-decker dustin-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. Thank you for the contribution, the thorough testing, and the configuration enhancements!

@dustin-decker dustin-decker merged commit cafdc99 into cruise-automation:master Jan 9, 2020
@dustin-decker
Copy link
Contributor

I will cut a release to include this soon.

@dustin-decker
Copy link
Contributor

dustin-decker commented Jan 17, 2020

Released in v1.3.0

@alpe alpe deleted the alex/size_limit_mutation_policy_36 branch January 21, 2020 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

emptyDir without sizelimit approach
2 participants