Skip to content

Commit

Permalink
Remove our “rpc” package (#481)
Browse files Browse the repository at this point in the history
As far as I can tell it has been completely superseded by [comlink](https://github.com/GoogleChromeLabs/comlink).

We also don’t use it in Webviz directly since we have our own RPC
implementation; we basically forgot to switch over to this package. I
also couldn’t find a reference to this package in any Cruise codebase.

If anyone still uses this they should just switch over to comlink. It
might be nice to do that in Webviz eventually too, but there’s no rush,
we can keep our local Rpc implementation for now.
  • Loading branch information
janpaul123 committed Jul 23, 2020
1 parent 8c21b14 commit 5a70385
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 408 deletions.
1 change: 0 additions & 1 deletion .eslintrc.js
Expand Up @@ -17,7 +17,6 @@ module.exports = {
"import/external-packages": [
"packages/@cruise-automation/button",
"packages/@cruise-automation/hooks",
"packages/@cruise-automation/rpc",
"packages/@cruise-automation/tooltip",
"packages/react-key-listener",
"packages/regl-worldview",
Expand Down
74 changes: 0 additions & 74 deletions packages/@cruise-automation/rpc/README.md

This file was deleted.

5 changes: 0 additions & 5 deletions packages/@cruise-automation/rpc/package-lock.json

This file was deleted.

19 changes: 0 additions & 19 deletions packages/@cruise-automation/rpc/package.json

This file was deleted.

138 changes: 0 additions & 138 deletions packages/@cruise-automation/rpc/src/index.js

This file was deleted.

0 comments on commit 5a70385

Please sign in to comment.