You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
Describe the bug
When downloading an episode and the subtitle-end-time exceeds the video-length crunchy-cli is trying to correct the end-time of the sub. But there is a bug, that the correction seems not to be formatted correctly.
To be more detailed: The line then ends up beginning for example with
Dialogue: 00:23:34.00,00:23:40.00,[...]
instead of
Dialogue: 0,0:23:34.00,0:23:40.00,[...]
(and is sorted to the beginning instead of remaining at the end).
The problem seems to be a missing “0,” (as “Layer,”-entry of the subtitle formating) between “Dialogue: ” and the start-time.
A consequence of this bug is, that this line and the next line of the subtitle is not displayed, when playing the video with vlc media player.
To Reproduce
Steps / command to reproduce the behavior:
$ crunchy archive -m video -a ja-JP --default-subtitle de-DE https://www.crunchyroll.com/series/G6793XKZY/ascendance-of-a-bookworm[E26]
When playing the video with vlc the first line “Nach Shicicozas Anfeindungen schossen\NTrombe aus dem Boden, die Myne umschlungen.” of the de-DE-subtitle is not displayed.
When extracting the de-DE-subtitle from the video the lines 33 to 37 read:
[Events]
Format: Layer,Start,End,Style,Name,MarginL,MarginR,MarginV,Effect,Text
Dialogue: 00:23:34.00,00:23:40.00,sign_33927_341_Illustration__No,,0000,0000,0000,,{\be3}Illustration: Shiina You
Dialogue: 0,0:00:01.57,0:00:05.48,Narrator,,0000,0000,0000,,Nach Shicicozas Anfeindungen schossen\NTrombe aus dem Boden, die Myne umschlungen.
Expected behavior
In the example of “To Reproduce” the line
Dialogue: 00:23:34.00,00:23:40.00,sign_33927_341_Illustration__No,,0000,0000,0000,,{\be3}Illustration: Shiina You
should instead read
Dialogue: 0,0:23:34.00,0:23:40.00,sign_33927_341_Illustration__No,,0000,0000,0000,,{\be3}Illustration: Shiina You
and not be sorted to the beginning of the [Events].
Client
OS: Windows 10
Version: v3.1.1
Additional context
As workaround i changed line 833 of crunchy-cli/cunchy-cli-core/src/utils/download.rs from
"Dialogue: {},{},",
to
"Dialogue: 0,{},{},",
but would prefer a solution, that uses the original Layer-entry of the subtitle formatting instead of just using “0,”. But my programming knowledge is limited, so it's difficult for me to find a proper fix myself.
The text was updated successfully, but these errors were encountered:
Describe the bug
When downloading an episode and the subtitle-end-time exceeds the video-length crunchy-cli is trying to correct the end-time of the sub. But there is a bug, that the correction seems not to be formatted correctly.
To be more detailed: The line then ends up beginning for example with
Dialogue: 00:23:34.00,00:23:40.00,[...]
instead of
Dialogue: 0,0:23:34.00,0:23:40.00,[...]
(and is sorted to the beginning instead of remaining at the end).
The problem seems to be a missing “0,” (as “Layer,”-entry of the subtitle formating) between “Dialogue: ” and the start-time.
A consequence of this bug is, that this line and the next line of the subtitle is not displayed, when playing the video with vlc media player.
To Reproduce
Steps / command to reproduce the behavior:
When playing the video with vlc the first line “Nach Shicicozas Anfeindungen schossen\NTrombe aus dem Boden, die Myne umschlungen.” of the de-DE-subtitle is not displayed.
When extracting the de-DE-subtitle from the video the lines 33 to 37 read:
Expected behavior
In the example of “To Reproduce” the line
should instead read
and not be sorted to the beginning of the [Events].
Client
Additional context
As workaround i changed line 833 of crunchy-cli/cunchy-cli-core/src/utils/download.rs from
to
but would prefer a solution, that uses the original Layer-entry of the subtitle formatting instead of just using “0,”. But my programming knowledge is limited, so it's difficult for me to find a proper fix myself.
The text was updated successfully, but these errors were encountered: