New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation errors are hard to read #13

Closed

jacksteamdev opened this issue Dec 5, 2019 · 1 comment · Fixed by #94

Assignees

Labels

Contributor

jacksteamdev commented Dec 5, 2019

Describe the bug
As is, the validation errors we emit are not very easy to read.

To Reproduce
Steps to reproduce the behavior:

Attempt to bundle a Chrome extension with an invalid manifest.
Try to decipher the JSON output logged to the console.

Expected behavior
The plugin should produce a concise, easy to understand error or series of errors and abort the bundle.

Additional information
Here's the code in question:
https://github.com/bumble-org/rollup-plugin-chrome-extension/blob/0a4499fb049205540e9f4523541487b980786f33/src/manifest-input/index.ts#L397-L403

jacksteamdev added the enhancement label

jacksteamdev self-assigned this

Contributor Author

jacksteamdev commented Jun 18, 2020

This is a library to look into: https://github.com/atlassian/better-ajv-errors

jacksteamdev mentioned this issue

Beta MV3 Support #94

Merged

8 tasks

jacksteamdev closed this as completed in #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment