Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hmr error #833

Merged
merged 3 commits into from
Jan 14, 2024
Merged

fix: hmr error #833

merged 3 commits into from
Jan 14, 2024

Conversation

ZainChen
Copy link
Contributor

Problems with hmr not updating files referenced by both background and other page components

Reason: For example, the dist/src/constants/message.ts.js file, which is referenced by background and other components, return []; prevents all of the default hmr behavior of handleHotUpdate. The default hmr cannot be blocked.

Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: eb9b6d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crxjs/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
vite-plugin-docs ⬜️ Ignored (Inspect) Visit Preview Jan 14, 2024 6:31pm

@jacksteamdev jacksteamdev added the vite-plugin Related to Vite plugin label Jan 14, 2024
@jacksteamdev jacksteamdev merged commit cc76555 into crxjs:main Jan 14, 2024
4 checks passed
Copy link
Contributor

@jacksteamdev jacksteamdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch ⚾ Thanks for the help!

@Jore
Copy link

Jore commented Feb 4, 2024

Thanks so much for this fix.

alajmo pushed a commit to alajmo/chrome-extension-tools that referenced this pull request Mar 24, 2024
* fix: hmr error

* Create bright-peaches-wink.md

---------

Co-authored-by: Jack Steam <jacksteamdev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vite-plugin Related to Vite plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants