Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localisation #45

Open
darnfish opened this issue Oct 19, 2019 · 2 comments · May be fixed by #65
Open

Localisation #45

darnfish opened this issue Oct 19, 2019 · 2 comments · May be fixed by #65
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@darnfish
Copy link
Contributor

I think we should work on trying to move all public strings to a directory, maybe l18n/en_US.json that contains all strings that are displayed to the client, so we can work on localisation for users in different languages, etc. Thoughts?
@darnfish darnfish added the enhancement New feature or request label Oct 19, 2019
@darnfish darnfish self-assigned this Oct 19, 2019
@Simonx22
Copy link
Contributor

Simonx22 commented Oct 19, 2019 •
edited
Loading

I like the idea! You might be able to apply at Transifex since Cryb is open source. Also I can help translating to German.

@NurMarvin
Copy link
Contributor

NurMarvin commented Oct 19, 2019 •
edited
Loading

Thought about implementing that myself but never went through with it.
I could help translating into German whenever this becomes a thing.
I would suggest using something like i18next or Project Fluent by Mozilla, even though I would push for Project Fluent considering it's designed to make translations sound more fluent where it's appropriate.

@NurMarvin NurMarvin linked a pull request Oct 22, 2019 that will close this issue
Open
@JeDaYoshi JeDaYoshi pinned this issue Feb 11, 2020
@JeDaYoshi JeDaYoshi added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load strings from external file instead of using hard coded values NurMarvin/web
4 participants
@JeDaYoshi @darnfish @NurMarvin @Simonx22