This repository has been archived by the owner on Sep 1, 2021. It is now read-only.
Avoid TEXTRELS https://bugs.gentoo.org/show_bug.cgi?id=439410 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid TEXTRELs (https://bugs.gentoo.org/show_bug.cgi?id=439410) we need to add fPic on 32bit too. Signed-off-by: Justin Lecher <jlec@gentoo.org>
|
@cryos Any feedback on merging this? Should I use Albert's approach? |
|
For simplicity I would consider just using this approach. I am not convinced the other approach will work as expected on Windows. This is far less disruptive too. |
|
Looks like master already has: So everyone gets -fPIC regardless of processor. Seems like that the's the right fix. |
This was referenced Apr 27, 2016
Closed
Closed
This was referenced Apr 27, 2016
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to avoid TEXTRELs (https://bugs.gentoo.org/show_bug.cgi?id=439410)
we need to add fPic on 32bit too.
Signed-off-by: Justin Lecher jlec@gentoo.org