Skip to content
This repository has been archived by the owner on Sep 1, 2021. It is now read-only.

Fix some scan coverity reports + typo #7

Closed
wants to merge 2 commits into from
Closed

Fix some scan coverity reports + typo #7

wants to merge 2 commits into from

Conversation

serval2412
Copy link
Contributor

Fix some coverity scan reports + typo

[libavogadro/src/extensions/cartesianextension.cpp:406]: (performance) Prefer prefix ++/-- operators for non-primitive types.
[libavogadro/src/extensions/surfaces/openqube/gaussianset.cpp:354] -> [libavogadro/src/extensions/surfaces/openqube/gaussianset.cpp:356]: (warning) Variable 'skip' is reassigned a value before the old one has been used. 'break;' missing?
(+ other similar warnings)
[libavogadro/src/python/sip.cpp:406]: (style) Statements following return, break, continue, goto or throw will never be executed.
[libavogadro/src/textrenderer_p.cpp:215]: (error) Memory leak: rawbitmap
[libavogadro/src/textrenderer_p.cpp:249]: (error) Memory leak: glyphbitmap
(+ other related)
@ghutchis
Copy link
Collaborator

ghutchis commented Aug 5, 2015

I'm going to close this - it doesn't merge cleanly and I think I already got most of the fixes from the other pull request.

@ghutchis
Copy link
Collaborator

ghutchis commented Aug 5, 2015

Sorry for the long-overdue merge.. I thought @cryos had taken care of this. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants