feat(agentplugin): add support for JMC agent plugin #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eleting templates
src/main/java/io/cryostat/core/agent/LocalProbeTemplateService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/core/agent/LocalProbeTemplateService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/core/agent/LocalProbeTemplateService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/core/agent/LocalProbeTemplateService.java
Outdated
Show resolved
Hide resolved
andrewazores
changed the title
andrewazores
reviewed
Nov 2, 2021
andrewazores
reviewed
Nov 2, 2021
andrewazores
reviewed
Nov 2, 2021
andrewazores
reviewed
Nov 2, 2021
andrewazores
reviewed
Nov 2, 2021
andrewazores
reviewed
Nov 2, 2021
andrewazores
reviewed
Nov 2, 2021
andrewazores
reviewed
Nov 2, 2021
andrewazores
reviewed
Nov 2, 2021
andrewazores
reviewed
Nov 2, 2021
andrewazores
reviewed
Nov 2, 2021
src/main/java/io/cryostat/core/agent/LocalProbeTemplateService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/core/agent/AbstractProbeTemplateService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/core/agent/LocalProbeTemplateService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/core/agent/LocalProbeTemplateService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/core/agent/LocalProbeTemplateService.java
Outdated
Show resolved
Hide resolved
src/main/java/io/cryostat/core/agent/LocalProbeTemplateService.java
Outdated
Show resolved
Hide resolved
…face, clean up getLocalTemplates
…g exceptions in AgentJMXHelper
Closed
andrewazores
approved these changes
Nov 12, 2021
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2021
* Basic agent functionality (TODO: Method & field capturing xml model) * Added more classes for agent probe xml modelling, added support for deleting templates * Cleaning up localProbetemplateService, adding XML Validation * Cleanup, adding tests, implementing getTemplate * Remove extraneous non-nls tags, cleanup, rework probeTemplate.deserialize * Remove extraneous non-nls tags * clean up unnecessary catches, turn ProbeTemplateService into an interface, clean up getLocalTemplates * Renaming ProbeTemplateService * Adding invalid converter/relation key to exception message, rethrowing exceptions in AgentJMXHelper * running spotless (cherry picked from commit ace15ef)
andrewazores
pushed a commit
that referenced
this pull request
Nov 16, 2021
* Basic agent functionality (TODO: Method & field capturing xml model) * Added more classes for agent probe xml modelling, added support for deleting templates * Cleaning up localProbetemplateService, adding XML Validation * Cleanup, adding tests, implementing getTemplate * Remove extraneous non-nls tags, cleanup, rework probeTemplate.deserialize * Remove extraneous non-nls tags * clean up unnecessary catches, turn ProbeTemplateService into an interface, clean up getLocalTemplates * Renaming ProbeTemplateService * Adding invalid converter/relation key to exception message, rethrowing exceptions in AgentJMXHelper * running spotless (cherry picked from commit ace15ef) Co-authored-by: Joshua Matsuoka <Josh.matsuoka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94
This PR adds the necessary classes for modelling agent probe templates, as well as a local probe template service for managing them in storage, and an Agent JMX Helper for communicating with the agent over JMX.