Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(topology): disable group node actions while checking #1049

Merged
merged 1 commit into from Jun 6, 2023
Merged

chore(topology): disable group node actions while checking #1049

merged 1 commit into from Jun 6, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jun 6, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Related to #906

Description of the change:

Disable gorup node actions while performing check with backend.

Motivation for the change:

In cases where network is slow, the users will not be able to perform actions when the checking is in progress.

chore(topology): disable group node actions while checking
6fa57b6 
Signed-off-by: Thuan Vo <thvo@redhat.com>
@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label Jun 6, 2023
@tthvo tthvo requested a review from andrewazores June 6, 2023 18:25
@mergify mergify bot added the safe-to-test label Jun 6, 2023
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1049-6fa57b6684e00e74264b88f71b00d7e8fa202dbb sh smoketest.sh

@andrewazores andrewazores merged commit 4ccacf7 into cryostatio:main Jun 6, 2023
25 of 26 checks passed
mergify bot pushed a commit that referenced this pull request Jun 6, 2023
@mergify
chore(topology): disable group node actions while checking (#1049)
a449e71 
Signed-off-by: Thuan Vo <thvo@redhat.com>
(cherry picked from commit 4ccacf7)
@mergify mergify bot mentioned this pull request Jun 6, 2023
Merged
@tthvo tthvo deleted the group-node branch June 6, 2023 18:54
@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1049-6fa57b6684e00e74264b88f71b00d7e8fa202dbb sh smoketest.sh

andrewazores pushed a commit that referenced this pull request Jun 6, 2023
@mergify
chore(topology): disable group node actions while checking (#1049) (#…
3ef5a2c 
…1050)

Signed-off-by: Thuan Vo <thvo@redhat.com>
(cherry picked from commit 4ccacf7)

Co-authored-by: Thuan Vo <thvo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
backport chore Refactor, rename, cleanup, etc. safe-to-test
Projects
2.4.0 release
Status: Done
2.3.1 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tthvo @andrewazores