Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Sentry #20

Merged
merged 7 commits into from
Jul 27, 2019
Merged

Sentry #20

merged 7 commits into from
Jul 27, 2019

Conversation

tanneberger
Copy link
Contributor

@tanneberger tanneberger commented Jul 23, 2019

Description

Added Sentry at important point where error may occur the stack-trace and given relevant data to find the origin of the bug will be piped into a log file. Which should be than sit in a docker volume.

Related Issue

#19

Motivation and Context

Test Driven Development

How Has This Been Tested?

tested

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@tanneberger tanneberger added the enhancement New feature or request label Jul 23, 2019
@tanneberger tanneberger self-assigned this Jul 23, 2019
@tanneberger
Copy link
Contributor Author

This introduces new Environment Variables PATH_LOGFILE, DSN, RELEASE

@tanneberger tanneberger changed the title added sentry and logging (#19) sentry Jul 25, 2019
@tanneberger tanneberger changed the title sentry Sentry Jul 25, 2019
Copy link
Contributor

@use-to use-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Please improved the code based on this review within a few days.

README.md Show resolved Hide resolved
cryptic/__init__.py Outdated Show resolved Hide resolved
cryptic/__init__.py Show resolved Hide resolved
cryptic/__init__.py Show resolved Hide resolved
cryptic/__init__.py Show resolved Hide resolved
cryptic/__init__.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
@tanneberger tanneberger requested a review from use-to July 26, 2019 16:27
Copy link
Contributor

@use-to use-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, but just respect my feedback to this pr.
So i dont want to discuss about unnecessary typings at here...

Some little fixes should be done!

README.md Show resolved Hide resolved
cryptic/__init__.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
@tanneberger
Copy link
Contributor Author

tanneberger commented Jul 27, 2019

@use-to I am using the black linter .... and the style changes you suggest are not conform with this pep8 enforcing tool -> black -l 120 . -> black only starts wrapping the dict over multiple lines when the line surpasses 120 characters. It would unnecessary work too check after every code clean up. Black also places the , at the last element of list and inputs and it is pep8 conform so.

@tanneberger tanneberger requested a review from use-to July 27, 2019 13:45
Copy link
Contributor

@use-to use-to left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@tanneberger tanneberger merged commit fe9e458 into experimental Jul 27, 2019
@Defelo Defelo deleted the issue/19-sentry branch July 27, 2019 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants