-
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This introduces new Environment Variables PATH_LOGFILE, DSN, RELEASE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Please improved the code based on this review within a few days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better, but just respect my feedback to this pr.
So i dont want to discuss about unnecessary typings at here...
Some little fixes should be done!
@use-to I am using the black linter .... and the style changes you suggest are not conform with this pep8 enforcing tool -> black -l 120 . -> black only starts wrapping the dict over multiple lines when the line surpasses 120 characters. It would unnecessary work too check after every code clean up. Black also places the , at the last element of list and inputs and it is pep8 conform so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thank you!
Description
Added Sentry at important point where error may occur the stack-trace and given relevant data to find the origin of the bug will be piped into a log file. Which should be than sit in a docker volume.
Related Issue
#19
Motivation and Context
Test Driven Development
How Has This Been Tested?
tested
Types of changes
Checklist: