Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: slashing module not enabled in the current code #46

Merged
merged 1 commit into from
Sep 9, 2020
Merged

Problem: slashing module not enabled in the current code #46

merged 1 commit into from
Sep 9, 2020

Conversation

devashishdxt
Copy link
Collaborator

Solution: Added slashing module. Fixes #35.

tomtau
tomtau suggested changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe also add it to sim test: https://github.com/crypto-com/chain-main/blob/master/app/sim_test.go#L150 ?

@devashishdxt
Problem: slashing module not enabled in the current code
a448cdd 
Solution: Added slashing module. Fixes #35.
@devashishdxt
Copy link
Collaborator Author

maybe also add it to sim test: https://github.com/crypto-com/chain-main/blob/master/app/sim_test.go#L150 ?

Done.

@tomtau
Copy link
Contributor

tomtau commented Sep 9, 2020

/runsim

1 similar comment
@tomtau
Copy link
Contributor

tomtau commented Sep 9, 2020

/runsim

@tomtau tomtau mentioned this pull request Sep 9, 2020
Closed
@tomtau
Copy link
Contributor

tomtau commented Sep 9, 2020

#47

tomtau
tomtau approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise seems ok

calvinaco
calvinaco approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@calvinaco calvinaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG2M

@tomtau tomtau merged commit dc7475f into master Sep 9, 2020
@tomtau tomtau deleted the devashishdxt branch September 9, 2020 04:07
damoncro pushed a commit to damoncro/chain-main that referenced this pull request Oct 25, 2021
@yihuang
Problem: no governance managed native to contract mapping (crypto-org…
dd99df4 
…-chain#81)

* Problem: no governance managed native to contract mapping

Closes: crypto-org-chain#46

gov token mapping integration test

fix proposal registration

fix integration test

* fix integration test

* rename

* fix python format
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomtau tomtau tomtau approved these changes

@calvinaco calvinaco calvinaco approved these changes

@yihuang yihuang Awaiting requested review from yihuang

@leejw51crypto leejw51crypto Awaiting requested review from leejw51crypto

@linfeng-crypto linfeng-crypto Awaiting requested review from linfeng-crypto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: slashing module not enabled in the current code
3 participants
@devashishdxt @tomtau @calvinaco