cleanup

x/feemarket/keeper/params.go

@@ -26,15 +26,11 @@ import (
 
 // GetParams returns the total set of fee market parameters.
 func (k Keeper) GetParams(ctx sdk.Context) (params types.Params) {
-	defer func() {
-		if r := recover(); r != nil {
-			k.Logger(ctx).Error("failed to get params", "error", r)
-			params = types.DefaultParams()
-		}
-	}()
 	bz := ctx.KVStore(k.storeKey).Get(types.ParamsKey)
 	if len(bz) == 0 {
 		k.ss.GetParamSetIfExists(ctx, &params)
+		// avoid nil pointers when params are not set
+		params.FillDefaults()
 	} else {
 		k.cdc.MustUnmarshal(bz, &params)
 	}

x/feemarket/types/params.go

@@ -144,6 +144,18 @@ func (p Params) GetBaseFee() *big.Int {
 	return p.BaseFee.BigInt()
 }
 
+func (p *Params) FillDefaults() {
+	if p.BaseFee.IsNil() {
+		p.BaseFee = sdkmath.NewIntFromUint64(params.InitialBaseFee)
+	}
+	if p.MinGasPrice.IsNil() {
+		p.MinGasPrice = DefaultMinGasPrice
+	}
+	if p.MinGasMultiplier.IsNil() {
+		p.MinGasMultiplier = DefaultMinGasMultiplier
+	}
+}
+
 func validateMinGasPrice(i interface{}) error {
 	v, ok := i.(sdkmath.LegacyDec)