Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse for websocket connID (backport: #1685) #239

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Apr 27, 2023

for more info: evmos#1685

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@mmsqe mmsqe changed the base branch from master to release/v0.20.x-cronos April 27, 2023 03:42
@mmsqe mmsqe requested a review from yihuang April 27, 2023 03:42
@mmsqe mmsqe force-pushed the cronos/v0.20.x-cronos-backport-1685 branch from 59f6f10 to ccb3f9b Compare May 15, 2023 03:29
@mmsqe mmsqe merged commit bad31ab into crypto-org-chain:release/v0.20.x-cronos May 15, 2023
mmsqe added a commit that referenced this pull request Jun 14, 2023
* fix parse for websocket connID

* update doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants