Problem: query blocks before enable feemarket module get nil pointer … #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #485 +/- ##
===========================================
- Coverage 61.53% 61.52% -0.02%
===========================================
Files 127 127
Lines 9477 9484 +7
===========================================
+ Hits 5832 5835 +3
- Misses 3107 3113 +6
+ Partials 538 536 -2
|
mmsqe
commented
May 14, 2024
| bz := ctx.KVStore(k.storeKey).Get(types.ParamsKey) | ||
| if len(bz) == 0 { | ||
| k.ss.GetParamSetIfExists(ctx, ¶ms) | ||
| // avoid nil pointers when params are not set | ||
| params.FillDefaults() |
There was a problem hiding this comment.
actually it's panic from store.parent.Get before get from subspace
There was a problem hiding this comment.
why parent get will have panic?
There was a problem hiding this comment.
the store won't be nil if it's registered in the binary, just the data could be missing.
There was a problem hiding this comment.
when query old version, cacheStore will be nil right?
There was a problem hiding this comment.
I guess if we have this: crypto-org-chain/cosmos-sdk#435, we don't need this?
yihuang
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…error
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)