Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: decode tx is unnecessary in tx listener #491

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jun 7, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 20 lines in your changes missing coverage. Please review.

Project coverage is 61.56%. Comparing base (97a30f8) to head (bb14414).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #491   +/-   ##
========================================
  Coverage    61.56%   61.56%           
========================================
  Files          127      128    +1     
  Lines         9473     9476    +3     
========================================
+ Hits          5832     5834    +2     
  Misses        3103     3103           
- Partials       538      539    +1     
Files Coverage Δ
rpc/stream/rpc.go 0.00% <0.00%> (ø)
app/ante/handler_options.go 61.90% <20.00%> (-1.06%) ⬇️
app/app.go 76.30% <20.00%> (+0.45%) ⬆️
app/ante/tx_listener.go 0.00% <0.00%> (ø)

@mmsqe mmsqe marked this pull request as ready for review June 9, 2024 12:44
@mmsqe mmsqe requested a review from yihuang June 9, 2024 12:44
@mmsqe mmsqe merged commit 217e3af into crypto-org-chain:develop Jun 9, 2024
37 of 39 checks passed
@yihuang yihuang deleted the tx_listener branch June 9, 2024 14:03
mmsqe added a commit that referenced this pull request Jun 10, 2024
* Problem: decode tx is unnecessary in tx listener

* cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants