Smaller bites of PR383 of crypto101/book #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvh
reviewed
Oct 15, 2020
src/exclusive-or.rst
Outdated
| thinking of XOR as a programmable inverter, and then looking at a | ||
| If an attacker sees the ciphertext, we can prove that | ||
| zero information is learned about the plaintext without the key. This property is | ||
| called *perfect security*. The proof can be understood intuitively. |
There was a problem hiding this comment.
Whoa! I get that this doesn't change that word but this should absolutely say "perfect secrecy" not "perfect security".
There was a problem hiding this comment.
Oh right. It's a cryptography term
lvh
approved these changes
Oct 15, 2020
|
Can you please make that one change, and then I'd be happy to merge. |
|
I changed the wording to "perfect secrecy" |
|
Looks great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smaller portions reviewed for PR383
I added some inline feedback on above link where I could contribute