Fix BitBox02 timeout issue #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I couldn't reproduce the issue myself, but got one user so far confirming this works. |
|
does the timeout happen while unlocking the bitbox02? I might have hit this issue too, so I could test this fix |
|
@djpnewton , not exactly, the issue is that it seems to happen to some users even after unlocking the BitBox02. Could not reproduce myself, but if you can it'll be very helpful! |
|
I've created https://github.com/cryptoadvance/specter-desktop/releases/tag/v1.3.1-pre2 in order to test this PR. |
ben-kaufman
added a commit
to ben-kaufman/specter-desktop
that referenced
this pull request
Apr 22, 2021
* Fix BitBox02 timeout issue * Longer timeout * Update hwi.js Co-authored-by: Kim Neunert <k9ert@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue where the request to the BitBox02 throws error due to the timeout.