Redesign the Tor settings screen #1245
Conversation
|
Just tested this and the The test_tor action assumes that the type of the connection is via-specter. However if it's custom this will throw an exception: I had my difficulties with getting the logs anyway so maybe try/except it inside the get_logs-function and return a reasonable text is the most resilient fix for this? Also, if the internal tor-daemon is running, you shouldn't be able to switch to custom as the user is assuming that if he clicks "Test Tor", he's testing the custom implementation. But if the custom-implementation is "accidentally" pointing to the internal tor-installation, the test is still "sucessfull". The Tor-logs are only obtainable when the log-daemon is not running. So i'd recommend to also dump the logs by default when you're stopping the daemon. Hope that makes sense. |
| logger.error(app.specter.tor_daemon.get_logs()) | ||
| if tor_type == "builtin": | ||
| logger.error("Tor-Logs:") | ||
| logger.error(app.specter.tor_daemon.get_logs()) |
There was a problem hiding this comment.
This won't work if tor is running properly. If it's not running properly, it's no wonder the test failed.
So maybe the best move here is stopping tor, getting the logs and start it again?!
|
Can you also put |
Redesign the Tor setup screen based on feedback from https://www.youtube.com/watch?v=Lq77qFFOBcE