Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TxList and AddressList classes for Liquid #1280

Merged
merged 10 commits into from
Jul 9, 2021

Conversation

stepansnigirev
Copy link
Collaborator

This PR improves the compatibility of Liquid functionality with Bitcoin functionality of Specter. Fixes some issues in Liquid like tracking of used addresses (still shows 0 amount though).
PR is getting pretty big so I decided to make it now and continue integration work in the next ones.

Core changes:

  • Wallet class creates _transactions and _addresses cache not from hard-coded classes but from one defined in the class. This means LWallet can just use different classes and the rest of functions remain the same.
  • LAddressList class allows lookups not only by confidential address but also by unconfidential addresses. The returned value is a confidential address.
  • TxList stores full raw transaction not in CSV but in a separate directory now. Storing raw transactions in CSV was causing problems if tx is too large (either in case of liquid with all the proofs or just huge bitcoin transactions)
  • Export to CSV now doesn't include raw transactions (causing problems for people, reported in Telegram channel)

Other changes

  • get_address_from_dict is slightly modified to support more options where address or addresses is stored - can be directly in the dict or in scriptPubKey of it. Raises an error if address is not found or address is Fee (liquid)
  • gettransaction function in the wallet can accept more arguments: full if you need hex field with full hex transaction, decode if you want to decode transaction.
  • Other minor changes

@stepansnigirev stepansnigirev merged commit 1f2e257 into cryptoadvance:master Jul 9, 2021
@stepansnigirev stepansnigirev deleted the txlist branch July 9, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants