Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logging #1282

Merged
merged 7 commits into from
Jul 9, 2021
Merged

improve logging #1282

merged 7 commits into from
Jul 9, 2021

Conversation

k9ert
Copy link
Collaborator

@k9ert k9ert commented Jul 8, 2021

  • We now have a --tracerpc switch which will dump each and every call to core/elements in the debug-logs like e.g.:
[  DEBUG] in             rpc: call(wallet/specter/mytrezor_2   ) payload:[{'method': 'listtransactions', 'params': ['*', 1000, 0, True], 'jsonrpc': '2.0', 'id': 0}]
[  DEBUG] in             rpc: call(wallet/specter/mytrezor_2   ) payload:[]
[  DEBUG] in             rpc: call(wallet/specter/mytrezor_2   ) payload:[{'method': 'getwalletinfo', 'params': [], 'jsonrpc': '2.0', 'id': 0}]
  • We have a different logging-scheme for dev than for production (no timestamps and a bit more structure for dev)

@stepansnigirev
Copy link
Collaborator

Looks good to me, except exit() thing above

@ben-kaufman ben-kaufman merged commit 5ac6173 into cryptoadvance:master Jul 9, 2021
@k9ert k9ert deleted the improve_logging branch February 22, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants