Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds steps to install Rust compiler dependency #1303

Merged
merged 4 commits into from
Jul 16, 2021

Conversation

kdmukai
Copy link
Collaborator

@kdmukai kdmukai commented Jul 14, 2021

The updated cryptography==3.4.x dependency requires a Rust compiler. Updating docs with steps to install Rust compiler. Windows instructions are minimal for now.

kdmukai and others added 2 commits July 13, 2021 21:48
The updated `cryptography==3.4.x` dependency requires a Rust compiler. Updating docs with steps to install Rust compiler. Windows instructions are minimal for now.
@k9ert
Copy link
Collaborator

k9ert commented Jul 15, 2021

Good point. I've struggled already a bit with that in #1232
I hope that this is an intermediate problem and imho also related to the python-version and the platform people are using.
If they provide a wheel-pakage for the combination, the compiler is not needed:

Right? In my PR mentioned above, as far as i can remember, i moved from debian:something to ubuntu:focal and avoided the compiler doing that.
Does it make sense so mention it?

@kdmukai
Copy link
Collaborator Author

kdmukai commented Jul 15, 2021

If they provide a wheel-pakage for the combination, the compiler is not needed:

@k9ert Ah, great info! I've slightly reorganized and updated the doc to reflect this.

@k9ert k9ert merged commit 3bee49e into cryptoadvance:master Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants