Showing the version with the settings-screen #158
Conversation
There was a problem hiding this comment.
Looks good! Correctly checks versions, if the current version is the latest red bar doesn't appear.
The test is red though...
Another thing I am thinking of, at the moment this red bar appears only in the settings screen. I suggest adding it to the "/" route as well, because by default "/" is redirected to the first wallet if it exists and the probability that the user will not see the update message is pretty high.
Also makes sense to change the version to the latest in setup.py:
https://github.com/cryptoadvance/specter-desktop/blob/master/setup.py#L17
| version_info["current"], version_info["latest"], version_info["upgrade"] = get_version_info() | ||
| app.logger.info("Upgrade? {}".format(version_info["upgrade"])) | ||
| if version_info["upgrade"]: | ||
| flash("There is a new version available. Consider strongly to upgrade to the new version {}".format(version_info["latest"])) |
There was a problem hiding this comment.
Maybe makes sense to add a hint how to update, like:
Update to {version_info["latest"]} with "pip3 install {name} --upgrade"
and get the package name from get_version_info() as well
There was a problem hiding this comment.
Not sure why the package_name should get returned. It's cryptoadvance.specter, right?
Fiex the other stuff.
|
I'm not sure why "some checks haven't completed yet" as they clearly did. |
Looks like this: