Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor logic + cleanup + bug fixes #160

Merged
merged 31 commits into from Jun 18, 2020

Conversation

ben-kaufman
Copy link
Contributor

@ben-kaufman ben-kaufman commented Jun 9, 2020

Copy link
Collaborator

@stepansnigirev stepansnigirev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When broadcasting the transaction I get an error:
'Specter' object has no attribute 'wallets' in controller.py line 70.

Otherwise ACK :)

@ben-kaufman
Copy link
Contributor Author

@stepansnigirev thanks for testing, I've encountered it while continuing the refactoring too, I think now it should be fine.
Not sure if we should merge this already so it doesn't get too big, or wait to complete the refactoring of wallets and devices here as a single PR, so whatever you think is better.

@stepansnigirev
Copy link
Collaborator

I think let's continue refactoring here. It would be nice to finish splitting device and wallet classes in this PR.

@k9ert
Copy link
Collaborator

k9ert commented Jun 14, 2020

LGTM so far. I was a bit concerned that renaming logic.py back to specter.py (which caused trouble in the past) would again cause trouble, but that doesn't seem to be the case.
But i guess we agree that this needs to be backwards-compatible for v0.19.1, right?!

Copy link
Collaborator

@stepansnigirev stepansnigirev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid sorting of the pubkeys...

src/cryptoadvance/specter/wallet.py Outdated Show resolved Hide resolved
src/cryptoadvance/specter/helpers.py Show resolved Hide resolved
Copy link
Collaborator

@stepansnigirev stepansnigirev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes for managing sortedmulti - by deafult we should try to use sortedmulti, if we fail - then we run a per-address addition.
The changes also batch all requests into a single rpc call.

src/cryptoadvance/specter/wallet_manager.py Outdated Show resolved Hide resolved
src/cryptoadvance/specter/wallet.py Outdated Show resolved Hide resolved
@ben-kaufman ben-kaufman merged commit 1b71c55 into cryptoadvance:master Jun 18, 2020
@ben-kaufman ben-kaufman deleted the refactor-logic branch June 18, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants