proper pinning of bitcoind-version in different branches #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is it red? |
…op into bitcoind_version_dep
|
Now it's green. There was an unnecessary git pull somehere in the code. Whether this successfully works will need to have a branch as well. After merge, i would do a test with a fresh branch. In fact, we should probably change that so that all tests are run twice: Once on v0.19 and once on v0.20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We might want to support different bitcoind-versions on different branches in the future. This change prepares this.
The used version of bitcoin is from now on no longer "latest" (or master) but specified in pytest.ini.
This version will be expected to be existing as a docker-container or as a tag on github.com/bitcoin/bitcoin