Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump hwi, add non-witness-utxo #178

Merged
merged 1 commit into from Jun 30, 2020
Merged

bump hwi, add non-witness-utxo #178

merged 1 commit into from Jun 30, 2020

Conversation

stepansnigirev
Copy link
Collaborator

Closes #150 and maybe #169

HWI released new version with segwit vuln fix.
This PR:

  • upgrades HWI
  • adds non-witness-utxo to transactions for hwi device
  • removes non-witness-utxo if witness-utxo is present for compatibility with Bitcoin Core
  • a few more small cleanups in hwi files

Tested with Trezor T and ColdCard. Ledger is in the office - gonna test tomorrow.

ben-kaufman
ben-kaufman approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@ben-kaufman ben-kaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Ledger and Trezor One, works great on both.

@stepansnigirev stepansnigirev merged commit cb4df1f into cryptoadvance:master Jun 30, 2020
@stepansnigirev stepansnigirev deleted the bump-hwi branch July 2, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-kaufman ben-kaufman ben-kaufman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annoying attack on segwit transactions
2 participants
@stepansnigirev @ben-kaufman