Chore: Tagging specterext-dummy #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for specter-desktop-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@relativisticelectron i've tagged you for reviewing but it's more like a "please notice". This is related to #1942 |
k9ert
requested review from
moneymanolis
and removed request for
relativisticelectron
moneymanolis
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Extension-generation process is dependent on the specterext-dummy template-repo:
https://github.com/cryptoadvance/specterext-dummy
So as soon as extgen code changes, there might be incompatibilities between both repos. So this PR creates a tag in that repo with the same version-number than the tag of the specter-desktop-release.
It needs two additional env-vars in the gitlab-CICD-var-section (https://gitlab.com/k9ert/specter-desktop/-/settings/ci_cd):
known_hostsas it would be created accepting the fingerprint of the github-servers.