Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve copy for incomplete transactions tab #1972

Merged
merged 6 commits into from Dec 2, 2022
Merged

Conversation

otkstudio
Copy link
Contributor

As mentioned in this issue: #1803

The text here should probably read "Transactions Awaiting Signing/Not Yet Broadcast To The Network"

The fix in this PR is a small copy change to make it clear that the "Unsigned" tab actually includes both unsigned and unbroadcasted transactions. I've renamed the tab to "Incomplete" and added further clarity to the states that are included in the tab when inside it as per @k9ert's suggestion:

So a reasonable (not too long) text would be "Transactions Awaiting Signing/Broadcasting" ?

@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for specter-desktop-docs canceled.

Name Link
🔨 Latest commit cb3276a
🔍 Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/6389dbc36d7e4b000991be32

…ing functionality is broken in transactions table
@k9ert
Copy link
Collaborator

k9ert commented Nov 21, 2022

I'd like to see screenshots for all ui-related changes. It's a great way of backtracking changes and makes it much more explicit what have changed and why. Can you add that?

@otkstudio
Copy link
Contributor Author

otkstudio commented Nov 21, 2022

@k9ert Sure! The issue was that in the send/unigned tab it included both unsigned and unbroadcasted transactions, but it didn't show that unbroadcasted transactions would/should exist here. This is a copy change to make that more clear. The discussion for this issue can be found here: #1803

Here are the before and after screenshots.

Before:
Screen Shot 2022-11-21 at 11 09 40 AM

After:
Screen Shot 2022-11-21 at 11 12 08 AM

@relativisticelectron
Copy link
Collaborator

I think "Incomplete" is even less fitting than "Unsigned". What about "Saved" (borrowed this terminology from electrum, where one can "save" a transactional locally, meaning it is not yet broadcasted but may be signed).

@moneymanolis
Copy link
Collaborator

I like "Saved" - incomplete is really not so great. A signed tx that you only need to broadcast is not sth. I'd intuitively consider "Incomplete". @otkstdio can you change if you are okay with it?

@otkstudio
Copy link
Contributor Author

@relativisticelectron @moneymanolis Great suggestion! I like "Saved" more to. I prefer things that lean more positive in their language so this is a nice improvement.

@otkstudio
Copy link
Contributor Author

@relativisticelectron @moneymanolis Updated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants