-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve copy for incomplete transactions tab #1972
Conversation
✅ Deploy Preview for specter-desktop-docs canceled.
|
…ing functionality is broken in transactions table
I'd like to see screenshots for all ui-related changes. It's a great way of backtracking changes and makes it much more explicit what have changed and why. Can you add that? |
@k9ert Sure! The issue was that in the send/unigned tab it included both unsigned and unbroadcasted transactions, but it didn't show that unbroadcasted transactions would/should exist here. This is a copy change to make that more clear. The discussion for this issue can be found here: #1803 Here are the before and after screenshots. |
I think "Incomplete" is even less fitting than "Unsigned". What about "Saved" (borrowed this terminology from electrum, where one can "save" a transactional locally, meaning it is not yet broadcasted but may be signed). |
I like "Saved" - incomplete is really not so great. A signed tx that you only need to broadcast is not sth. I'd intuitively consider "Incomplete". @otkstdio can you change if you are okay with it? |
@relativisticelectron @moneymanolis Great suggestion! I like "Saved" more to. I prefer things that lean more positive in their language so this is a nice improvement. |
@relativisticelectron @moneymanolis Updated 👍 |
As mentioned in this issue: #1803
The fix in this PR is a small copy change to make it clear that the "Unsigned" tab actually includes both unsigned and unbroadcasted transactions. I've renamed the tab to "Incomplete" and added further clarity to the states that are included in the tab when inside it as per @k9ert's suggestion: