Cleanup:(tx-table) Remove arrows and clickable headers on transactions table #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing functionality is broken in transactions table
✅ Deploy Preview for specter-desktop-docs canceled.
|
|
Good! Can you do screenshots before/after? |
|
Just fyi, @otkstdio I just removed the arrow for the time column. |
moneymanolis
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the transactions sortability is broken i've removed the clickability and arrows to avoid confusing the user. This is mentioned in both #1805 and #1925. Following @k9ert suggestion to just remove the arrows for now while the core functionality doesn't work.