Feature: delete spectrum node #2047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for specter-desktop-docs canceled.
|
k9ert
commented
Jan 11, 2023
| @@ -48,8 +48,13 @@ | |||
| </select> | |||
| </div> | |||
| <div class="row" style="margin-top: 25px"> | |||
| <button type="submit" class="btn">{{ _("Save") }}</button> | |||
There was a problem hiding this comment.
"Connect" instead of "Save"
k9ert
commented
Jan 11, 2023
| if action == "delete": | ||
| if node_is_running_before_request: | ||
| ext().disable_spectrum() | ||
| flash("Spectrum Node deleted") |
There was a problem hiding this comment.
Spectrum Node disconnected!
k9ert
commented
Jan 11, 2023
| ext().disable_spectrum() | ||
| flash("Spectrum Node deleted") | ||
| else: | ||
| flash("There is no node running, can't delete", "error") |
|
When I try to delete the Spectrum node I get:
OK, the reason for that was that the node was setup without this PR code, works if the node is setup with it. |
moneymanolis
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the user can delete Spectrum Nodes.
Also we're fixing cryptoadvance/spectrum#13 with a3414c3