Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pg_config to prerequisits #2053

Merged
merged 1 commit into from Jan 16, 2023
Merged

Add pg_config to prerequisits #2053

merged 1 commit into from Jan 16, 2023

Conversation

aphex3k
Copy link
Contributor

@aphex3k aphex3k commented Jan 13, 2023 •
edited

This fixes #1997 for docker builds and command line installs

image

@netlify
Copy link

netlify bot commented Jan 13, 2023 •
edited

✅ Deploy Preview for specter-desktop-docs canceled.

Name Link
🔨 Latest commit c526851
🔍 Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/63c0cf1650a1180008520f37

@aphex3k aphex3k marked this pull request as draft January 13, 2023 01:55
@aphex3k aphex3k changed the title Add psycopg2 binary to requirements Add pg_config to requirements Jan 13, 2023
@aphex3k aphex3k marked this pull request as ready for review January 13, 2023 01:57
@aphex3k aphex3k changed the title Add pg_config to requirements Add pg_config to prerequisits Jan 13, 2023
@aphex3k aphex3k marked this pull request as draft January 13, 2023 02:57
@aphex3k
Copy link
Contributor Author

aphex3k commented Jan 13, 2023

(pardon the messy history, I'm working from a new computer and it isn't quite configured to my liking yet)

@aphex3k aphex3k marked this pull request as ready for review January 13, 2023 03:39
@k9ert
Copy link
Collaborator

k9ert commented Jan 13, 2023

Great! Can you also pip-compile the requirements.in?
https://docs.specter.solutions/desktop/development/#some-words-about-dependencies
Thanks!

@aphex3k
Copy link
Contributor Author

aphex3k commented Jan 13, 2023 •
edited

Great! Can you also pip-compile the requirements.in? https://docs.specter.solutions/desktop/development/#some-words-about-dependencies Thanks!

Interestingly enough, the hashes for the missing library had already been in the requirements.txt all along. It had only been missing from the .in. See https://github.com/cryptoadvance/specter-desktop/blob/master/requirements.txt#L480

@k9ert k9ert merged commit e019658 into cryptoadvance:master Jan 16, 2023
@k9ert
Copy link
Collaborator

k9ert commented Jan 16, 2023

Ah, yes! Thank you very much!

@aphex3k aphex3k deleted the patch-1 branch January 16, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k9ert k9ert k9ert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip-installation of 1.14.0-pre3 fails in certain situations
2 participants
@aphex3k @k9ert