Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Add missing signet key #2368

Merged
merged 4 commits into from Aug 23, 2023

Conversation

moneymanolis
Copy link
Collaborator

Signet was missing in get_rpcconfig() resulting in such an error:

Traceback (most recent call last):
  File "/Users/manolis/.pyenv/versions/.specter/lib/python3.10/site-packages/flask/app.py", line 1523, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/manolis/.pyenv/versions/.specter/lib/python3.10/site-packages/flask/app.py", line 1509, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**req.view_args)
  File "/Users/manolis/.pyenv/versions/.specter/lib/python3.10/site-packages/flask_login/utils.py", line 290, in decorated_view
    return current_app.ensure_sync(func)(*args, **kwargs)
  File "/Users/manolis/coding/repos/specter-desktop/src/cryptoadvance/specter/server_endpoints/nodes.py", line 68, in node_settings_new_node_get
    node = Node.from_json(
  File "/Users/manolis/coding/repos/specter-desktop/src/cryptoadvance/specter/node.py", line 348, in from_json
    return cls(
  File "/Users/manolis/coding/repos/specter-desktop/src/cryptoadvance/specter/node.py", line 327, in __init__
    self.rpc = self._get_rpc()
  File "/Users/manolis/coding/repos/specter-desktop/src/cryptoadvance/specter/node.py", line 395, in _get_rpc
    rpc_conf_arr = autodetect_rpc_confs(
  File "/Users/manolis/coding/repos/specter-desktop/src/cryptoadvance/specter/rpc.py", line 207, in autodetect_rpc_confs
    conf_arr.extend(_detect_rpc_confs_via_datadir(datadir=datadir))
  File "/Users/manolis/coding/repos/specter-desktop/src/cryptoadvance/specter/rpc.py", line 141, in _detect_rpc_confs_via_datadir
    if "rpcuser" in config["bitcoin.conf"][network]:
KeyError: 'signet'

@moneymanolis moneymanolis added the bug Something isn't working label Aug 22, 2023
@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for specter-desktop-docs canceled.

Name Link
🔨 Latest commit bc80184
🔍 Latest deploy log https://app.netlify.com/sites/specter-desktop-docs/deploys/64e61169bbcacf0008a443e4

@stepansnigirev
Copy link
Collaborator

Test fails.

@moneymanolis
Copy link
Collaborator Author

@stepansnigirev fixed the tests.

@moneymanolis moneymanolis merged commit 622e111 into cryptoadvance:master Aug 23, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants