Fix install_noded.sh #2422
Merged
Fix install_noded.sh #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for specter-desktop-docs canceled.
|
k9ert
reviewed
May 15, 2024
| @@ -87,5 +80,9 @@ def test_node_running_elements(caplog, request): | |||
| prepare_elements_default_wallet(my_elementsd) | |||
| random_address = "el1qqf6tv4n8qp55qc04v4xts5snd9v5uurkry4vskef6lmecahj6c42jt9lnj0432287rs67z9vzq2zvuer036s5mahptwxgyd8k" | |||
| my_elementsd.testcoin_faucet(random_address, amount=25) | |||
| finally: | |||
There was a problem hiding this comment.
The finally is still needed, no? Stopping the node should be done in any case.
|
Sorry it took so long. However currently i have time to review this and your other PR. |
k9ert
approved these changes
May 16, 2024
|
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install_noded.shfile.grep "addopts = --${node_impl}d-version"misses an "development.mdfile.closes #2420