-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more languages for mnemonics #2424
Conversation
✅ Deploy Preview for specter-desktop-docs canceled.
|
test.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this needs deletion.
Thanks for your contribution and sorry for the late feedback. |
np, thanks! |
This is now released: https://github.com/cryptoadvance/specter-desktop/releases/tag/v2.0.3 |
I think we shouldn't encourage users to store mnemonics in other languages to avoid dead ends because of the lack of support from other wallets and possible mistakes by the users. A quantitative study with 990 Bitcoin users by Krombholz et al. reported that 22.5% of respondents had lost Bitcoins at least once. The majority of incidents was caused by user mistakes (43.2%). |
This pr will add support for french, japanese, czech and portuguese. It does this by using a newer version (v0.21) of the python-mnemonic package. The tests are updated to check if the new languages are created and detected correctly.
Removed this part:
specter-desktop/src/cryptoadvance/specter/util/mnemonic.py
Lines 53 to 60 in a052373
The
detect_language()
function takes into account ambiguity and returns an error if a language cannot successfully be determined in the new version of python-mnemonic.