Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect to pending transactions in /send if there are any #245

Merged
merged 3 commits into from Jul 18, 2020
Merged

redirect to pending transactions in /send if there are any #245

merged 3 commits into from Jul 18, 2020

Conversation

stepansnigirev
Copy link
Collaborator

Pending transactions are locking funds used in these transactions and people get confused.
This PR redirects to pending transactions screen from /send tab if there are any pending transactions.
If there are no pending transaction we load the usual /send/new tab.

@ben-kaufman
Copy link
Contributor

Good idea, but currently this breaks the menu bar in the send tab if you have unsigned txs. You can't navigate to the New tab... I think it's just a matter of updating the menu stuff for wallet_send to wallet_sendnew.

@stepansnigirev
Copy link
Collaborator Author

Fixed!

@ben-kaufman
Copy link
Contributor

Now that works, but the Open button of an unsigned PSBT stopped working with a similar error.

@stepansnigirev
Copy link
Collaborator Author

Damn... I hope I fixed it everywhere now

Copy link
Contributor

@ben-kaufman ben-kaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great now :)

@stepansnigirev stepansnigirev merged commit 48ccca1 into cryptoadvance:master Jul 18, 2020
@stepansnigirev stepansnigirev deleted the pending-first branch July 18, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants