Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release binaries #324

Merged
merged 9 commits into from Sep 1, 2020
Merged

Conversation

k9ert
Copy link
Collaborator

@k9ert k9ert commented Aug 28, 2020

see #323

For now, only linux binaries get created and uploaded.

@stepansnigirev
Copy link
Collaborator

I cherry-picked fix the build commit to fix the build on master. Was broken by #322
Do you think it's realistic to get build jobs for osx, win and aarch64 in this PR?

@k9ert
Copy link
Collaborator Author

k9ert commented Aug 28, 2020

Gitlab provides its runner-binary for windows and MacOS. They even have publicly available windows runners. I'm not too happy to use them for security-reasons, though. Building and testing is one thing (which we're already not covering with public but a private runner) but releasing is even more security critical.

@stepansnigirev
Copy link
Collaborator

So if I understand this PR correctly, it will create a unix binary and upload it to your fork, right?

@k9ert
Copy link
Collaborator Author

k9ert commented Aug 31, 2020

Yes, that was wrong (fixed). Also there is documentation missing which i should put to https://github.com/cryptoadvance/specter-desktop/blob/master/docs/continuous-integration.md
Give me some more time and i'll try to create a windows-binary as well. There i have to fiddle around with picking the right runner. When i have that, maybe someone else can do the same for MacOS binaries (I don't own a Mac but can provide a windows-runner).
By the way i really think we should restrict ourself to private runners. Sooner or later we want to sign the builds (and hash them before that). Even though it might be possible on public runners, it's a very bad idea imho.

@stepansnigirev stepansnigirev merged commit e145a91 into cryptoadvance:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants