Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #256 - btc-node-config via env-vars #351

Merged
merged 1 commit into from Sep 4, 2020

Conversation

k9ert
Copy link
Collaborator

@k9ert k9ert commented Sep 3, 2020

copied from the info-popup below:

When auto-detect is on, Specter will check for Environment-Variables (BTC_RPC_USER, BTC_RPC_PASSWORD, BTC_RPC_HOST, BTC_RPC_PORT) to configure the connection or attempt to automatically locate your Bitcoin data
directory and load your node configurations from it.

@k9ert
Copy link
Collaborator Author

k9ert commented Sep 3, 2020

Usually you probably use the env-vars if you connect to a remote-host. That should be https by default. If you really want to do something stupid (e.g. for testing reasons) you can still specify BTC_RPC_PROTOCOL=http .

@k9ert
Copy link
Collaborator Author

k9ert commented Sep 3, 2020

copied from the other issue. PR+issues is confusing to me in Github.

Looks good, I just don't understand why https by default - it will break autodetect for local nodes...

Not sure i understand your concern. If the env-vars are specified, local-autodetection is no longer used anyway.
Note that the env-solution will only work if all 4 env-vars are defined. Otherwise i hope everything else works as before.
https://github.com/k9ert/specter-desktop/blob/rpc-envvar-config/src/cryptoadvance/specter/rpc.py#L123-L135
It returns an empty array if not all 4 (but not the protocol) is defined.
At least that was my intention. So shouldn't break the autodetection?

@stepansnigirev
Copy link
Collaborator

Oh, got it. Then it should be fine, sorry!

@stepansnigirev stepansnigirev merged commit 056ad68 into cryptoadvance:master Sep 4, 2020
@k9ert k9ert deleted the rpc-envvar-config branch September 4, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants