Cleanups #352
Merged
Cleanups #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. As long as checks have passed, i'd merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started some minor refactoring of the codebase, created a
utilfolder with potentially useful isolated modules.Ideally the whole
helpers.pyshould be splitted into modules and moved to util.At the moment
utilcontains:base58encoding-decoding toolsxpubtools for slip132 conversion and fingerprint extractionbcurtools for Cobomerkleblockproofstorhidden service utilsjson_rpcclass used by HWIBridge (and by SpecterRPC in the future)Even though I almost didn't change the code, things may break because I didn't change imports properly.